[15.0][IMP] stock_barcodes: Add update_barcodes_wiz_after_changes method

stock_barcodes/models/stock_move_line.py

@@ -27,14 +27,15 @@
         self.qty_done = 0.0
 
     def action_barcode_detailed_operation_unlink(self):
-        for sml in self:
-            stock_move = sml.move_id
-            stock_move.barcode_backorder_action = "pending"
-            sml.unlink()
-            # HACK: To force refresh wizard values
-            wiz_barcode = self.env["wiz.stock.barcodes.read.picking"].browse(
-                self.env.context.get("wiz_barcode_id", False)
-            )
-            stock_move._action_assign()
-            wiz_barcode.fill_todo_records()
-            wiz_barcode.determine_todo_action()
+        stock_moves = self.move_id
+        self.unlink()
+        stock_moves.barcode_backorder_action = "pending"
+        # TODO: Any alternative to cover all cases without reassign?
+        stock_moves._action_assign()
+        # HACK: To force refresh wizard values
+        wiz_barcode = self.env["wiz.stock.barcodes.read.picking"].browse(
+            self.env.context.get("wiz_barcode_id", False)
+        )
+        wiz_barcode.with_context(
+            skip_clean_values=True
+        ).update_barcodes_wiz_after_changes()

stock_barcodes/models/stock_picking.py

@@ -32,8 +32,7 @@ def action_barcode_scan(self, option_group=False):
         wiz = self.env["wiz.stock.barcodes.read.picking"].create(
             self._prepare_barcode_wiz_vals(option_group)
         )
-        wiz.fill_pending_moves()
-        wiz.determine_todo_action()
+        wiz.with_context(skip_clean_values=True).update_barcodes_wiz_after_changes()
         action = self.env["ir.actions.actions"]._for_xml_id(
             "stock_barcodes.action_stock_barcodes_read_picking"
         )

stock_barcodes/models/stock_picking_type.py

@@ -44,8 +44,7 @@ def action_barcode_scan(self):
         ):
             vals["location_dest_id"] = self.default_location_dest_id.id
         wiz = self.env["wiz.stock.barcodes.read.picking"].create(vals)
-        wiz.fill_pending_moves()
-        wiz.determine_todo_action()
+        wiz.with_context(skip_clean_values=True).update_barcodes_wiz_after_changes()
         action = self.env["ir.actions.actions"]._for_xml_id(
             "stock_barcodes.action_stock_barcodes_read_picking"
         )

stock_barcodes/static/src/js/form_view.js

@@ -5,6 +5,7 @@ odoo.define("stock_barcodes.FormView", function (require) {
     "use strict";
 
     var FormView = require("web.FormView");
+    var FormController = require("web.FormController");
 
     FormView.include({
         /**
@@ -21,4 +22,14 @@ odoo.define("stock_barcodes.FormView", function (require) {
             return params;
         },
     });
+
+    FormController.include({
+        _barcodeActiveScanned: function () {
+            this._super(...arguments);
+            var record = this.model.get(this.handle);
+            if (record.model.includes("wiz.stock.barcodes.read")) {
+                $("#dummy_on_barcode_scanned").click();
+            }
+        },
+    });
 });

stock_barcodes/tests/test_stock_barcodes.py

@@ -164,6 +164,9 @@ def _create_barcode_option_group(cls):
     def action_barcode_scanned(self, wizard, barcode):
         wizard._barcode_scanned = barcode
         wizard._on_barcode_scanned()
+        # Method to call all methods outside of onchange environment for pickings read
+        if wizard._name != "wiz.stock.barcodes.new.lot":
+            wizard.dummy_on_barcode_scanned()
 
     def test_wizard_scan_location(self):
         self.action_barcode_scanned(self.wiz_scan, "8411322222568")

stock_barcodes/wizard/stock_barcodes_read.py

@@ -459,7 +459,10 @@ def _clean_barcode_scanned(self, barcode):
 
     def on_barcode_scanned(self, barcode):
         self.barcode = self._clean_barcode_scanned(barcode)
-        self.process_barcode(barcode)
+
+    def dummy_on_barcode_scanned(self):
+        """To avoid execute operations in onchange environment"""
+        self.process_barcode(self.barcode)
 
     def check_location_contidion(self):
         if not self.location_id:

stock_barcodes/wizard/stock_barcodes_read_picking.py

@@ -183,8 +183,7 @@
         # view, so for create a candidate picking with the same default picking
         # we need create it in this onchange
         self._set_default_picking()
-        self.fill_pending_moves()
-        self.determine_todo_action()
+        self.update_barcodes_wiz_after_changes()
 
     def get_sorted_move_lines(self, move_lines):
         location_field = self.option_group_id.location_field_to_sort
@@ -298,6 +297,26 @@
     def update_fields_after_determine_todo(self, move_line):
         self.picking_product_qty = move_line.qty_done
 
+    def update_barcodes_wiz_after_changes(self):
+        if not self.keep_screen_values or self.todo_line_id.state != "pending":
+            if not self.env.context.get("skip_clean_values", False):
+                self.action_clean_values()
+            keep_vals = {}
+        else:
+            keep_vals = self._convert_to_write(self._cache)
+        self.fill_todo_records()
+        if self.forced_todo_key:
+            self.todo_line_id = self.pending_move_ids.filtered(
+                lambda ln: str(self._group_key(ln)) == self.forced_todo_key
+            )[:1]
+            self.selected_pending_move_id = self.todo_line_id
+            self.determine_todo_action(self.todo_line_id)
+        else:
+            self.determine_todo_action()
+        self.action_show_step()
+        if keep_vals:
+            self.update_keep_values(keep_vals)
+
     def action_done(self):
         # Skip read log creation to be able to pass log_detail when available.
         res = super(
@@ -310,24 +329,7 @@
                 self[self._field_candidate_ids].scan_count += 1
                 if self.env.context.get("force_create_move"):
                     self.move_line_ids.barcode_scan_state = "done_forced"
-                if not self.keep_screen_values or self.todo_line_id.state != "pending":
-                    if not self.env.context.get("skip_clean_values", False):
-                        self.action_clean_values()
-                    keep_vals = {}
-                else:
-                    keep_vals = self._convert_to_write(self._cache)
-                self.fill_todo_records()
-                if self.forced_todo_key:
-                    self.todo_line_id = self.pending_move_ids.filtered(
-                        lambda ln: str(self._group_key(ln)) == self.forced_todo_key
-                    )[:1]
-                    self.selected_pending_move_id = self.todo_line_id
-                    self.determine_todo_action(self.todo_line_id)
-                else:
-                    self.determine_todo_action()
-                self.action_show_step()
-                if keep_vals:
-                    self.update_keep_values(keep_vals)
+                self.update_barcodes_wiz_after_changes()
             # Force refresh candidate pickings to show green if not pending moves
             if not self.pending_move_ids:
                 self._set_candidate_pickings(self.picking_id)

stock_barcodes/wizard/stock_barcodes_read_todo.py

@@ -99,9 +99,7 @@
         self.state = "pending"
         self.line_ids.barcode_scan_state = "pending"
         self.line_ids.qty_done = 0.0
-        self.wiz_barcode_id.action_clean_values()
-        self.wiz_barcode_id.fill_todo_records()
-        self.wiz_barcode_id.determine_todo_action()
+        self.wiz_barcode_id.update_barcodes_wiz_after_changes()
 
     def action_back_line(self):
         if self.position_index > 0:
@@ -146,7 +144,10 @@
             ):
                 rec.state = "done"
             else:
-                rec.state = "pending"
+                if rec.stock_move_ids[:1].barcode_backorder_action == "pending":
+                    rec.state = "pending"
+                else:
+                    rec.state = "done_forced"
 
     @api.model
     def fields_to_fill_from_pending_line(self):

stock_barcodes/wizard/stock_barcodes_read_views.xml

@@ -458,6 +458,17 @@
                         </div>
                         <!-- HACK: To avoid inheritance crash -->
                         <button name="action_manual_entry" invisible="1" />
+                        <!-- Hide button in view to allow do onclick in JS. Use d-none instead of
+                             invisible attribute to be allocated by jquery selector
+                         -->
+                        <button
+                            name="dummy_on_barcode_scanned"
+                            id="dummy_on_barcode_scanned"
+                            type="object"
+                            data-hotkey="99"
+                            invisible="0"
+                            class="d-none"
+                        />
                         <!-- // -->
                         <button
                             name="action_clean_values"
@@ -472,7 +483,7 @@
                             name="action_confirm"
                             type="object"
                             class="btn-success ml-auto oe_kanban_action_button btn-sm pl-3 pr-3"
-                            attrs="{'invisible': ['|', '|','&amp;', ('is_manual_confirm', '=', False), ('manual_entry', '=', False), ('display_menu', '=', True), ('visible_force_done', '=', True)]}"
+                            attrs="{'invisible': ['|', '|','&amp;', '&amp;', ('is_manual_confirm', '=', False), ('manual_entry', '=', False), ('is_manual_qty', '=', False), ('display_menu', '=', True), ('visible_force_done', '=', True)]}"
                             data-hotkey="8"
                         >
                             <i class="fa fa-check" title="Confirm" />

stock_barcodes_picking_batch/models/stock_picking_batch.py

@@ -30,8 +30,7 @@ def action_barcode_scan(self):
         if option_group.get_option_value("location_dest_id", "filled_default"):
             vals["location_dest_id"] = first_picking.location_dest_id.id
         wiz = self.env["wiz.stock.barcodes.read.picking"].create(vals)
-        wiz.determine_todo_action()
-        wiz.fill_pending_moves()
+        wiz.with_context(skip_clean_values=True).update_barcodes_wiz_after_changes()
         action = self.env["ir.actions.act_window"]._for_xml_id(
             "stock_barcodes_picking_batch.action_stock_barcodes_read_picking_batch"
         )

stock_barcodes_picking_batch/wizard/stock_barcodes_read_picking_batch.py

@@ -82,7 +82,7 @@
         # We are in a wizard view, so for create a candidate picking batch
         # with the same default picking batch we need create it in this onchange
         self._set_default_picking_batch()
-        self.determine_todo_action()
+        self.update_barcodes_wiz_after_changes()
 
     def get_sorted_move_lines(self, move_lines):
         if self.picking_mode != "picking_batch":