[18.0][MIG] stock_picking_product_assortment #2262
Conversation
… assortment This module allow to use the product assortment related to partners on outgoing stock pickings.
…ension module to extend product domain. Unnecessary code removed
bosd
force-pushed
the
18.0-mig-stock_picking_product_assortment
branch
from
31a4173 to
7f3a12e
Compare
bosd
force-pushed
the
18.0-mig-stock_picking_product_assortment
branch
from
7f3a12e to
a043b71
Compare
|
Let's go now OCA/product-attribute#1904 is merged |
|
@PieterPaulussen |
| operation="domain_add" | ||
| condition="parent.has_assortment" | ||
| > | ||
| [('id', 'in', parent.assortment_product_ids)] |
There was a problem hiding this comment.
@bosd This should not be solved here, but have you tested this with resulting large domains? This will work fine and well for a small set, but for large results... an ('id', 'in', parent.assortment_product_ids) is really inefficient.
Is there no way to invert the domain like ('assortment_id', 'in', parent.assortment_ids)?
There was a problem hiding this comment.
@PieterPaulussen I did not test this module with large domains or data sets.
I've tried the code suggestion, but it did'nt work yet.
| This module allows to use the product assortments related to a partner | ||
| on stock pickings. Whith this implementation, on stock pickings, we only allow to | ||
| select the products defined on the assortment and we don't allow to select | ||
| products which are not defined in the whitelist on the assortment. |
There was a problem hiding this comment.
What about the blacklisted products?
There was a problem hiding this comment.
Good catch. I've changed it to make it more clear and general.
There was a problem hiding this comment.
@jbaudoux Is this PR ok for you now?
Co-authored-by: Jacques-Etienne Baudoux <[email protected]>
bosd
force-pushed
the
18.0-mig-stock_picking_product_assortment
branch
from
c248653 to
8b32452
Compare
folluw up of: OCA/stock-logistics-workflow#1858