Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] stock_picking_purchase_order_link: Migration to 18.0 #1809

Open
wants to merge 37 commits into
base: 18.0
Choose a base branch
from

Conversation

HeliconiaSolutions
Copy link

No description provided.

AdriaGForgeFlow and others added 30 commits December 26, 2024 10:26
As odoo mentioned this changes here:
odoo/odoo#53335
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/pt_BR/
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/it/
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/fr/
Copy link

@rjaraspearhead rjaraspearhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

self.product = self.product_product_obj.create(
{
"name": "product_template_obj - Test",
# "type": "product",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The equivalent is:

Suggested change
# "type": "product",
"type": "consu",
"is_storable": True,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@celm1990 , Thanks for the suggestions! Please review.

@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-stock_picking_purchase_order_link branch from 518df7d to f1828e9 Compare February 4, 2025 06:11
- Adria Gil Sorribes \<<[email protected]>\>
- Jaume Planas \<<[email protected]>\>
- Joan Mateu Jordi \<<[email protected]>\>
- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove backticks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeliconiaSolutions @StefanRijnhart As already said elsewhere, in CONTRIBUTORS.rst should appear individual contributors (even if company can be set as title).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis for my information, I remember this being debated but is there a guideline published somewhere or a statement from the board?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a common guideline in opensource projects. Contributors are individuals. There is author part for companies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a company by itself does not write code nor documentation 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis So if the company is removed from the list of contributors it's ok for you?

@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-stock_picking_purchase_order_link branch from f1828e9 to 960798f Compare February 6, 2025 04:58
@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-stock_picking_purchase_order_link branch from 960798f to fc5ae99 Compare February 7, 2025 12:46
@HeliconiaSolutions HeliconiaSolutions force-pushed the 18.0-mig-stock_picking_purchase_order_link branch from fc5ae99 to b6f1e0f Compare February 11, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.