-
-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] stock_picking_purchase_order_link: Migration to 18.0 #1809
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] stock_picking_purchase_order_link: Migration to 18.0 #1809
Conversation
As odoo mentioned this changes here: odoo/odoo#53335
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/pt_BR/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/it/
Currently translated at 100.0% (2 of 2 strings) Translation: stock-logistics-workflow-16.0/stock-logistics-workflow-16.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-16-0/stock-logistics-workflow-16-0-stock_picking_purchase_order_link/fr/
… for Purchase Order Button
… for Purchase Order Button
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: stock-logistics-workflow-17.0/stock-logistics-workflow-17.0-stock_picking_purchase_order_link Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-17-0/stock-logistics-workflow-17-0-stock_picking_purchase_order_link/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
self.product = self.product_product_obj.create( | ||
{ | ||
"name": "product_template_obj - Test", | ||
# "type": "product", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equivalent is:
# "type": "product", | |
"type": "consu", | |
"is_storable": True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@celm1990 , Thanks for the suggestions! Please review.
518df7d
to
f1828e9
Compare
- Adria Gil Sorribes \<<[email protected]>\> | ||
- Jaume Planas \<<[email protected]>\> | ||
- Joan Mateu Jordi \<<[email protected]>\> | ||
- `Heliconia Solutions Pvt. Ltd. <https://www.heliconia.io>`_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove backticks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HeliconiaSolutions @StefanRijnhart As already said elsewhere, in CONTRIBUTORS.rst
should appear individual contributors (even if company can be set as title).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis for my information, I remember this being debated but is there a guideline published somewhere or a statement from the board?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a common guideline in opensource projects. Contributors are individuals. There is author part for companies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a company by itself does not write code nor documentation 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis So if the company is removed from the list of contributors it's ok for you?
stock_picking_purchase_order_link/tests/test_stock_picking_purchase_order_link.py
Outdated
Show resolved
Hide resolved
f1828e9
to
960798f
Compare
960798f
to
fc5ae99
Compare
fc5ae99
to
b6f1e0f
Compare
No description provided.