[16.0] [MIG] survey_formio #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module adds the necessary function to generate a form.io compatible JSON that represents an odoo survey. It also adds the function that creates or updates a survey_user_input when given the JSON returned by form.io
The dictionnary with the answer for a multiple choice question should only contain true answers.
Currently translated at 100.0% (2 of 2 strings) Translation: survey-13.0/survey-13.0-survey_formio Translate-URL: https://translation.odoo-community.org/projects/survey-13-0/survey-13-0-survey_formio/it/
jdoutreloux
reviewed
Mar 8, 2024
survey_formio/models/survey.py
Outdated
| for answer in multiple_choice_answers_dict.keys(): | ||
| answers_dict[question_id + "_" + answer[1:]] = answer[1:] | ||
| return answers_dict | ||
| return [value for value in multiple_choice_answers_dict.values() if value] |
There was a problem hiding this comment.
I've tested this and it seems there's an issue here.
Saving a multiple choice answer given by formio doesn't work. I think Odoo is waiting for the id of the answer, not its value (see : https://github.com/odoo/odoo/blob/16.0/addons/survey/tests/test_survey_ui_session.py#L210 )
I think this should be
return [value for value in multiple_choice_answers_dict.keys() if value] or something like that
ThomasBinsfeld
force-pushed
the
16.0-mig-survey_formio
branch
from
f419cdd
to
ae7a799
Compare
jdoutreloux
approved these changes
Mar 11, 2024
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From https://github.com/acsone/survey/tree/13.0/survey_formio