-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] membership_variable_period: Migration to 18.0 #201
Open
BhaveshHeliconia
wants to merge
43
commits into
OCA:18.0
Choose a base branch
from
HeliconiaIO:18.0-mig-membership_variable_period
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] membership_variable_period: Migration to 18.0 #201
BhaveshHeliconia
wants to merge
43
commits into
OCA:18.0
from
HeliconiaIO:18.0-mig-membership_variable_period
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variable period for memberships =============================== Current membership module allows to set products that define a fixed period for a membership. This is good when the quotas are defined periodically, and when you become a member, you are until the end of that quota cycle. But a lot of times, membership quotas express an amount of time that you gain the membership. For example, one year since the subscription. This module allows to make it in Odoo, using current membership features, and adapting them for this purpose. As now the quota is not attached to a fixed period, you can also invoice more than one quantity for being a member for the corresponding number of periods. Finally, a cron has been included that triggers the recalculation of the membership state, allowing to have "old members", which doesn't work well on standard. Usage ===== Define a member product, and select 'Variable periods' in the field *Membership type*. You will be able to select them the period for the membership in quantity and interval. Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_variable_period.pot Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_variable_period.pot Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-12.0/vertical-association-12.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_variable_period/ Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-12.0/vertical-association-12.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-12-0/vertical-association-12-0-membership_variable_period/pt_BR/ Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_variable_period.pot Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] Update membership_variable_period.pot Signed-off-by: Carmen Bianca Bakker <[email protected]> [UPD] README.rst Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/it/
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/it/
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/es/
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/pt/
…elds are always truthy This is an additional sanity check to make sure that fields that are expected to be available are actually available. The situation here is a little tricky. Especially as pertains date_from and date_to; these fields are `required=True` nowhere. Not on the product, not on the membership invoice, and not on the membership line. However, they _are_ set as required in the product and membership line views. If these values are ever empty, it's a sure sign that something went wrong somewhere, because the user should not be able to reach such a state via the UI. One sure way to reach that state was via the demo data, however, which had no start and end dates. This is now fixed. The situation for the variable period fields is similar. These fields should never be empty when the membership type is variable, and it's not typically possible to empty these values via the UI. For convenience's sake, I simply set them to required an sich, with a default value. Signed-off-by: Carmen Bianca BAKKER <[email protected]>
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/fr/
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/pt_BR/
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/ca/
Currently translated at 100.0% (12 of 12 strings) Translation: vertical-association-16.0/vertical-association-16.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-16-0/vertical-association-16-0-membership_variable_period/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: vertical-association-17.0/vertical-association-17.0-membership_variable_period Translate-URL: https://translation.odoo-community.org/projects/vertical-association-17-0/vertical-association-17-0-membership_variable_period/
This was referenced Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on