Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] web_responsive_attachment_preview #3058

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jan 15, 2025

This module restores the attachment preview on the right side of forms for example on invoices by standard Odoo when using web_responsive. The chatter in that case is always below the form. Note Odoo's cutoff is 1534px width, smaller screens never show the preview.

Use case is a controller going through invoices to confirm them, in that case it's pretty annoying to have to open the attachments and then the preview of the invoice's pdf manually a hundred times a day.

Technically, it removes this patch. (I still think web_responsive does too much at once and should be split up into several ones)

Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,
Tested on runboat, make sense
LGTM

@flotho
Copy link
Member

flotho commented Jan 15, 2025

any conflict with #2695 ?

@hbrunn
Copy link
Member Author

hbrunn commented Jan 15, 2025

they do basically the same thing, so one or the other should be merged. People on the other PR didn't seem enthusiastic to have it in the main module, that's why I added it as extra one

@pedrobaeza
Copy link
Member

I think that a exclusive view for reviewing invoices with the preview should exist, but most of the work with invoices shouldn't show the preview, as you don't need it, and you have to go to bottom to check the chatter, which is what you use most.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants