Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocrd workpace list-page: ignore files without pageId, fix #1148 #1151

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

kba
Copy link
Member

@kba kba commented Dec 12, 2023

Using list-page implies a need to know the list of pages, i.e. mets:div in the PHYSICAL structMap. So, we should not include None in the (generation of the) output list, which led to the issue raised in #1148.

@kba kba requested a review from MehmedGIT December 12, 2023 13:52
Copy link
Contributor

@MehmedGIT MehmedGIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That fixes the issue for both previously problematic workspaces I have tried with.

@kba kba merged commit c7e4b91 into master Dec 14, 2023
1 check passed
@kba kba deleted the list-page-skip-non-page-files branch August 13, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants