Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024 10 11 #452

Merged
merged 37 commits into from
Oct 15, 2024
Merged

Update 2024 10 11 #452

merged 37 commits into from
Oct 15, 2024

Conversation

kba
Copy link
Member

@kba kba commented Oct 10, 2024

Time for a new release!

Includes the just released v2.70.0 of OCR-D/core as well as Dockerfiles for most projects (ht @joschrew @bertsky for that effort), so we now have slim containers consistently.

Also includes a new processor ocrd-page2alto-transform that provides an OCR-D interface for https://github.com/OCR-D/page-to-alto directly, which is significantly faster than using it via ocrd-fileformat-transform -P from-to 'page alto'.

@kba kba requested review from MehmedGIT, bertsky and joschrew October 10, 2024 15:26
@bertsky
Copy link
Collaborator

bertsky commented Oct 11, 2024

@kba you can update ocrd_cis from bertsky/fix-alpha-shape now.

But it seems that page2alto is still broken:

0.140 Traceback (most recent call last):
0.140   File "/usr/local/bin/ocrd-page2alto-transform", line 5, in <module>
0.140     from ocrd_page_to_alto.ocrd_cli import main
0.140 ModuleNotFoundError: No module named 'ocrd_page_to_alto.ocrd_cli'

This was an editable install, so ...

@bertsky
Copy link
Collaborator

bertsky commented Oct 11, 2024

This was an editable install, so ...

Could this be interference from the older page-to-alto still packaged under ocrd_fileformat/repo/ocr-fileformat/vendor?

@kba
Copy link
Member Author

kba commented Oct 11, 2024

This was an editable install, so ...

Could this be interference from the older page-to-alto still packaged under ocrd_fileformat/repo/ocr-fileformat/vendor?

Yes, indeed, thanks. Updated.

- ocrd-calamari: no need to reinstall protobuf here anymore
- fix-cuda: downgrade Torch (to avoid conflicts around typing-extensions)
- ensure semaphore when creating venvs, too
- fix-cuda: same in sub-venv (avoid CUDA 12)
@bertsky
Copy link
Collaborator

bertsky commented Oct 11, 2024

It won't affect our (fat image) Docker build, but you can update dinglehopper after this once more, @kba.

@bertsky
Copy link
Collaborator

bertsky commented Oct 14, 2024

It won't affect our (fat image) Docker build, but you can update dinglehopper after this once more, @kba.

We also need qurator-spk/sbb_binarization#70 to avoid the TF conflict between eynollah and sbb_binarization – can you please update, @kba?

bertsky and others added 12 commits October 14, 2024 14:52
This is my first attempt at utilising the v2 API (for removal of temporary tags on Dockerhub).

- already contained: remove temporary images after deploy
- still missing: cleanup after build:
  - in case of failure: immediately
  - normally: if not on master, then when
    - on medium: remove minimum
    - on maximum: remove medium
    - _after_ maximum: remove maximum  
      (the problem with this is that the `docker push` is implemented as a `post-step` in the workflow def)
what is going on with envvars here?
@bertsky
Copy link
Collaborator

bertsky commented Oct 15, 2024

circleci-ocrdall

@bertsky
Copy link
Collaborator

bertsky commented Oct 15, 2024

Test upload now also working (CircleCI does not allow directly mounting volumes into Docker containers):
circleci-ocrdall

@bertsky bertsky merged commit 3e33522 into master Oct 15, 2024
1 check failed
@stweil stweil deleted the update-2024-10-11 branch October 16, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants