Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless exception #185

Merged
merged 1 commit into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/int32.ml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ let of_int64 = Int64.to_int32

let to_int64 = Int64.of_int32

exception Overflow

(* Unsigned comparison in terms of signed comparison. *)
let cmp_u x op y = op (add x min_int) (add y min_int)

Expand Down
2 changes: 0 additions & 2 deletions src/int32.mli
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

type t = int32

exception Overflow

val min_int : t

val max_int : t
Expand Down
2 changes: 0 additions & 2 deletions src/int64.ml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ let clz n = Stdlib.Int64.of_int (Ocaml_intrinsics.Int64.count_leading_zeros n)

let ctz n = Stdlib.Int64.of_int (Ocaml_intrinsics.Int64.count_trailing_zeros n)

exception Overflow

(* Taken from Base: https://github.com/janestreet/base *)
let popcnt =
let ( + ) = add in
Expand Down
2 changes: 0 additions & 2 deletions src/int64.mli
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

type t = int64

exception Overflow

val min_int : t

val max_int : t
Expand Down