A handful of tentative performance improvements #295
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zapashcanon
reviewed
Jun 5, 2024
zapashcanon
reviewed
Jun 5, 2024
zapashcanon
reviewed
Jun 5, 2024
zapashcanon
reviewed
Jun 5, 2024
zapashcanon
reviewed
Jun 5, 2024
src/symbolic/symbolic_choice.ml
Outdated
| @@ -366,7 +366,7 @@ let get_model_or_stop symbol = | |||
| | Some v -> return v | |||
| end | |||
|
|
|||
| let select (cond : Symbolic_value.vbool) = | |||
| let select_inner ?(explore_first = true) (cond : Symbolic_value.vbool) = | |||
There was a problem hiding this comment.
Could you use ~explore_first instead ? I don't really like optional arguments TBH, and here the function is used in only two places so it's not that tedious
|
LGTM once we checked that the 1st and 3rd one are actually leading to better results, which I would expect (+ my nitpicks comments). |
|
@krtab, I wanted to run the benchmarks on the server, but the code actually does not typecheck |
krtab
force-pushed
the
improv_multicore
branch
4 times, most recently
from
8501a5a to
4e76f58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zapashcanon let me know if you want them in separate PRs