Fixes #1332: Deep Comparison for Array-based Concurrency tokens. #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
requested review from
habbes,
mikepizzo,
xuzhg,
WanjohiSammy,
ElizabethOkerio and
gathogojr
|
@WanjohiSammy , may I interest you in this? |
|
@xuzhg, it's been a little quiet here. Maybe I can help with something? |
|
@xuzhg , @WanjohiSammy, I see you guys were busy with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1332
A popular convention today for concurrency check fields is to use a
byte[]field calledRowVersionwith aTimestamporConcurrencyCheckattribute.However, when using such a field, the
queryOptions.ifNoneMatch.ApplyTocall was having absolutely no effect. That's becauseApplyTowas internally usingExpression.Equalwhich is perfect for value types but doesn't fare very well against reference types or particularly Arrays.I fixed this by adding a case for arrays that, through a helper method, generates an expression that performs a deep comparison.