Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi @fmaussion and @lilianschuster,
Here is the latest attempt to fix all the pytests.
This commit fixes #50 #48
For one of the test I did a hard change by messing with some tolerances (these two changes test_hydro.py LINE#726 and test_hydro.pyLINES#734-747 needs checking).
I will open a new issue for the tests that are failing but if you pull this with the latest version of oggm:commit#1702 should have only be 3 test failing due to the issues that I listed here #51 :