Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptations for 2D redistribution #1746

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

pat-schmitt
Copy link
Member

@pat-schmitt pat-schmitt commented Sep 26, 2024

This PR is for discussing some possibilities for adapting the 2D redistribution.

It includes a new possibility for ranking the pixels in each elevation band (order in which pixels melt) and a function for calculating a median flowline (e.g. madian flowline from different gcms with the same scenario).

After some testing we can decide what we want to keep.

  • Tests added/passed
  • Fully documented (opened issues for tutorials)
  • Entry in whats-new.rst

@pep8speaks
Copy link

pep8speaks commented Sep 26, 2024

Hello @pat-schmitt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-20 10:31:38 UTC

@pat-schmitt
Copy link
Member Author

When tests pass, this PR is ready for merging.
It was already used for creating the latest visualizations (e.g. see https://edu.oggm.org/en/latest/glacier_videos.html).

@pat-schmitt pat-schmitt merged commit 5ac2eea into OGGM:master Dec 30, 2024
27 checks passed
@pat-schmitt pat-schmitt deleted the adapt_2d_redistribution branch December 30, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants