Disable blending for autogenerated shadow caster blend blocks. Fixed …

…Vulkan validation layer errors on Google Pixel 7 Pro, that does not supports VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BLEND_BIT for PFG_R32_FLOAT aka VK_FORMAT_R32_SFLOAT, that often used for shadow maps.
OGRECave · Sep 18, 2024 · 6bbe582 · 6bbe582
1 parent efba9f5
commit 6bbe582
Showing 1 changed file with 20 additions and 8 deletions.
diff --git a/OgreMain/src/OgreHlmsDatablock.cpp b/OgreMain/src/OgreHlmsDatablock.cpp
@@ -382,13 +382,19 @@ namespace Ogre
         if( !casterBlock && overrideCasterBlock )
         {
             mIgnoreFlushRenderables = true;
-            if( mBlendblock[0]->mAlphaToCoverage == HlmsBlendblock::A2cDisabled )
+            if( mBlendblock[0]->mAlphaToCoverage == HlmsBlendblock::A2cDisabled &&
+                mBlendblock[0]->mSourceBlendFactor == SBF_ONE &&
+                mBlendblock[0]->mDestBlendFactor == SBF_ZERO &&
+                ( !mBlendblock[0]->mSeparateBlend ||
+                  ( mBlendblock[0]->mSourceBlendFactorAlpha == SBF_ONE &&
+                    mBlendblock[0]->mDestBlendFactorAlpha == SBF_ZERO ) ) )
                 setBlendblock( mBlendblock[0], true );
             else
             {
-                HlmsBlendblock blendblockNoAC = *mBlendblock[0];
-                blendblockNoAC.mAlphaToCoverage = HlmsBlendblock::A2cDisabled;
-                setBlendblock( blendblockNoAC, true );
+                HlmsBlendblock casterBlendblock = *mBlendblock[0];
+                casterBlendblock.mAlphaToCoverage = HlmsBlendblock::A2cDisabled;
+                casterBlendblock.setBlendType( SBT_REPLACE );
+                setBlendblock( casterBlendblock, true );
             }
             mIgnoreFlushRenderables = false;
         }
@@ -419,13 +425,19 @@ namespace Ogre
         if( !casterBlock && overrideCasterBlock )
         {
             mIgnoreFlushRenderables = true;
-            if( mBlendblock[0]->mAlphaToCoverage == HlmsBlendblock::A2cDisabled )
+            if( mBlendblock[0]->mAlphaToCoverage == HlmsBlendblock::A2cDisabled &&
+                mBlendblock[0]->mSourceBlendFactor == SBF_ONE &&
+                mBlendblock[0]->mDestBlendFactor == SBF_ZERO &&
+                ( !mBlendblock[0]->mSeparateBlend ||
+                  ( mBlendblock[0]->mSourceBlendFactorAlpha == SBF_ONE &&
+                    mBlendblock[0]->mDestBlendFactorAlpha == SBF_ZERO ) ) )
                 setBlendblock( mBlendblock[0], true );
             else
             {
-                HlmsBlendblock blendblockNoAC = *mBlendblock[0];
-                blendblockNoAC.mAlphaToCoverage = HlmsBlendblock::A2cDisabled;
-                setBlendblock( blendblockNoAC, true );
+                HlmsBlendblock casterBlendblock = *mBlendblock[0];
+                casterBlendblock.mAlphaToCoverage = HlmsBlendblock::A2cDisabled;
+                casterBlendblock.setBlendType( SBT_REPLACE );
+                setBlendblock( casterBlendblock, true );
             }
             mIgnoreFlushRenderables = false;
         }