Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revamp performance capture #735

Open
fdefalco opened this issue Aug 16, 2023 · 1 comment
Open

revamp performance capture #735

fdefalco opened this issue Aug 16, 2023 · 1 comment
Assignees

Comments

@fdefalco
Copy link
Contributor

Currently query performance is captured in the output log and then later that log is parsed to pull out the run time for the queries. This parsing step will fail when there are errors in the log because it changes the format of those lines. I don't think this is a great approach and would rather refactor the performance metrics to be captured separately from the log and remove the need to then parse the log file for performance metrics.

@fdefalco fdefalco self-assigned this Aug 16, 2023
@fdefalco
Copy link
Contributor Author

fdefalco commented Aug 6, 2024

To achieve this create a new table called achilles_performance that will capture the start time, end time, duration and analysis id for each analysis. Remove the use of the parsing of the log file to obtain analysis performance results.

Also, the generation of the performance report that is generated will have to be updated.

https://github.com/OHDSI/Achilles/blob/main/R/exportToAres.R#L161

@fdefalco fdefalco added this to the Backlog Maintenance milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant