Skip to content

Commit 2d9c48b

Browse files
authored
Merge pull request #139 from OHDSI/user-conf
use not hashed password in configurations for new users.
2 parents b7b325c + aaeeaf8 commit 2d9c48b

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

datanode/config/config-dev.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ datanode:
2525
2626
firstName: Datanode
2727
lastName: Admin
28-
password: $2a$12$FLBjwwU2GOrCAASJg.E7N.uNiYd6rC4lLBN5hYmEiq49IPsMFnRxa
28+
password: password
2929
roles: ADMIN
3030
user:
3131
3232
firstName: Datanode
3333
lastName: User
34-
password: $2a$12$FLBjwwU2GOrCAASJg.E7N.uNiYd6rC4lLBN5hYmEiq49IPsMFnRxa
34+
password: password
3535
jwt:
3636
expiration: 604800
3737
executionEngine:

datanode/src/main/java/com/odysseusinc/arachne/datanode/auth/basic/DbBasicCredentialsService.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import java.time.Clock;
4141
import java.time.Instant;
4242
import java.util.List;
43-
import java.util.Objects;
4443
import java.util.Optional;
4544
import java.util.UUID;
4645

@@ -99,7 +98,7 @@ public void ensureRegistered(String login, String password, UserDTO info) {
9998
}
10099

101100
private CredentialsEntity updateIfPassDiffers(String login, String password, CredentialsEntity credentials) {
102-
if (!Objects.equals(password, credentials.getData())) {
101+
if (!passwordEncoder.matches(password, credentials.getData())) {
103102
log.info("On service account [{}], force updated password due to mismatch", login);
104103
credentials.setTerminated(Instant.now(clock));
105104
return create(password, credentials.getUser());

install/docker/datanode.env

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,5 @@ jasypt.encryptor.password=arachne
2424
datanode.users.admin.email=[email protected]
2525
datanode.users.admin.firstName=Datanode
2626
datanode.users.admin.lastName=Admin
27-
datanode.users.admin.password='$2a$10$JrltmCF6zqvfdpZTYOTM0uByU1Cx9C3X0x0iRQFqlXX3bTOEsWJae' # Bcrypt format
27+
datanode.users.admin.password='ohdsi'
2828
datanode.users.admin.roles='ADMIN'

0 commit comments

Comments
 (0)