Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No connection check when creating a database #11

Open
ttemnikova opened this issue Dec 22, 2023 · 3 comments
Open

No connection check when creating a database #11

ttemnikova opened this issue Dec 22, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@ttemnikova
Copy link

  1. Login to Arachne Data Node
  2. Go to Administration → Databases
  3. Click the “Create database“ button
  4. Fill in the fields so that it is impossible to connect to the data source using the defined connection string and credentials
  5. Click the “Save“ button

Expected result: the database is not saved, the user receives an appropriate error message (from the response): “Cannot establish connection to the data source“
Actual result: the database is saved

It seems that this is a regression.

@ttemnikova ttemnikova added the bug Something isn't working label Dec 22, 2023
@konstjar konstjar added this to the v2.0.1 milestone Feb 6, 2024
@konstjar konstjar modified the milestones: v2.0.1, v2.0.2 Feb 27, 2024
@dmitrys-odysseus
Copy link
Contributor

When running in docker mode, the same connection settings might not be usable for datanode and EE because of different container configuration. Those who are facing this situation might not have the power to change it and be fine with datanode not being able to connect to the datasource, as long as their analyses run.
The changes here should not block creating or updating datasources if check fails.
So, the check should be implemented as separate button and failure must not block create/update process, just tell the user that check failed and let him to proceed if he opts to.

@ttemnikova
Copy link
Author

The changes here should not block creating or updating datasources if check fails.

In this case we need to handle a situation when a user submits an analysis on a data source without established connection. For example, these submissions should not hang and the users should be informed about the problem with the data source.

@dmitrys-odysseus
Copy link
Contributor

This has to be handled in any case. Even if datasource is initially accessible, it might later stop being available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants