Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why do we have 2 different docker-compose files and environment settings? #29

Open
anthonysena opened this issue Jan 16, 2024 · 2 comments
Labels
question Further information is requested

Comments

@anthonysena
Copy link
Contributor

I was wondering why there are 2 different docker compose files in the repo?

  1. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose.yml
  2. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose-windows.yml

And that they reference different environment settings?

  1. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose.yml#L61
  2. https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose-windows.yml#L58

Shouldn't these reference https://github.com/OHDSI/Arachne/blob/master/install/docker/datanode-example.env? I had to change this locally to spin up my containers and was curious about this.

@anthonysena anthonysena added the question Further information is requested label Jan 16, 2024
@konstjar
Copy link
Contributor

Great question!

https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose-windows.yml

  • This version is used in combination with powershell script and it was designed for Windows.
  • This version uses tarball execution mode. And this is a reason for the different set of configuration options for Arachne Execution Engine.

https://github.com/OHDSI/Arachne/blob/master/install/docker/docker-compose.yml

  • Could be used as general version of Docker compose
  • Configured for Docker execution mode

The comment about datanode-example.env is reasonable. Let's rename it to avoid confusion.

@konstjar
Copy link
Contributor

datanode-example.env was renamed to datanode.env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants