better error if you apply the same inclusion criteria twice

[catalamarti]

No description provided.

[edward-burn]

@catalamarti @nmercadeb is this still an issue? If so, with a reprex I could take a look

[nmercadeb]

I think that what marti suggested is to throw and error if you do something like:

cdm$cohort |> requireSex(sex = "Female") |> requireSex(sex = "Female")

@catalamarti correct me if i'm wrong as i dont remember much what it was about

[edward-burn]

For me I think it is fine that this doesn't produce an error (but will not lead to another row of attrition with nobody dropped)

[edward-burn]

This is the current behaviour

library(omock)
#> Warning: package 'omock' was built under R version 4.4.1
library(CohortConstructor)
cdm <- mockCdmReference() |>
  mockPerson(nPerson = 100) |>
  mockObservationPeriod() |>
  mockCohort(
    name = "cohort",
    numberCohorts = 1
  )
cdm$cohort <- cdm$cohort |> 
  requireSex(sex = "Female") |> 
  requireSex(sex = "Female")
attrition(cdm$cohort)
#> # A tibble: 3 × 7
#>   cohort_definition_id number_records number_subjects reason_id reason          
#>                  <int>          <int>           <int>     <int> <chr>           
#> 1                    1            100              59         1 Initial qualify…
#> 2                    1             49              28         2 Sex requirement…
#> 3                    1             49              28         3 Sex requirement…
#> # ℹ 2 more variables: excluded_records <int>, excluded_subjects <int>

^{Created on 2024-09-24 with reprex v2.1.0}