Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings when no there are no concept counts #236

Open
nmercadeb opened this issue Jun 20, 2024 · 2 comments
Open

settings when no there are no concept counts #236

nmercadeb opened this issue Jun 20, 2024 · 2 comments
Labels
needs discussion

Comments

@nmercadeb
Copy link
Collaborator

Should we output an empty cohort with attributes populated for those codelists without ocurrences in the database?

Also, if a conceptSet is list(cohort1 = c(1, 2, 3), cohort2 = NULL), should the cohort2 be in the settings?

@catalamarti @edward-burn
@nmercadeb nmercadeb changed the title include settings if no concept occurrences are found? settings when no there are no concept counts Jun 20, 2024
@catalamarti
Copy link
Collaborator

Is cohort2 = NULL a valid codelist?

If yes, then it must be in the cohort settings, otherwise error for wrong inputs

@nmercadeb

@catalamarti
Copy link
Collaborator

If we allow this, then we have to fix this error in omopgenerics:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catalamarti @nmercadeb