Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When cohort counts are 0 warning not error should be thrown #832

Open
azimov opened this issue Jun 2, 2022 · 1 comment
Open

When cohort counts are 0 warning not error should be thrown #832

azimov opened this issue Jun 2, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@azimov
Copy link
Collaborator

azimov commented Jun 2, 2022

When a cohort table is empty CohortDiagnostics assume that CohortGenerator has not been ran; this is not necessarily the case as the cohorts may be empty. When Running on multiple data sets this creates problems as the execution will not finish cleanly and an error is thrown.

@azimov azimov added bug Something isn't working good first issue Good for newcomers labels Jun 2, 2022
@gowthamrao
Copy link
Member

Also related to this #754

as why not run orphan concepts and other diagnostics that only rely on cohort definition expression and not instantiated cohort table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants