Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohort Algebra operators - union, minus, intersect #95

Open
gowthamrao opened this issue Mar 22, 2023 · 2 comments · May be fixed by #193
Open

Cohort Algebra operators - union, minus, intersect #95

gowthamrao opened this issue Mar 22, 2023 · 2 comments · May be fixed by #193

Comments

@gowthamrao
Copy link
Member

gowthamrao commented Mar 22, 2023

I had built a package called CohortAlgebra that was able to do many of these algebraic operator on instantiated cohorts called CohortAlgebra. It works, but i am hoping that CohortGenerator would take on these. Reason: cohortGenerator has the pipe operations, handles cohort definition set, and can store the SQL in cohortDefinitionSet object.

The operators i would like to ask may be explained by these graphs

Cohort Union
image

Intersect example 1
image

Intersect example 2
image

Intersect example 3
image

Intersect example 4
image

Intersect example 5
image

Minus 1
image

Minus 2
image

@gowthamrao gowthamrao pinned this issue Mar 22, 2023
@gowthamrao gowthamrao unpinned this issue Mar 22, 2023
@anthonysena
Copy link
Collaborator

@gowthamrao - is this still a desire for CohortAlgebra? I'm unclear on if are proposing to relocate this logic into CohortGenerator or to provide more capabilities for using CohortAlgebra via CohortGenerator?

@gowthamrao
Copy link
Member Author

I am proposing to integrate the logic from CohortAlgebra to CohortGenerator. CohortAlgebra does the same thing as CohortGenerator i.e. generate new cohort from other cohorts.

@anthonysena anthonysena linked a pull request Sep 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants