Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to generate result json from results in database #367

Closed
edward-burn opened this issue Sep 30, 2022 · 3 comments
Closed

Function to generate result json from results in database #367

edward-burn opened this issue Sep 30, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@edward-burn
Copy link

At the moment I don't think there is any easy way to generate the result json from the results saved in the database. I was in this situation with someone else having run DQD and so I can see the results in the database but could not see a way to get the json results without having to rerun the analysis. That was until @MaximMoinat shared some bespoke code that meant I could do this. It would I think be helpful to make this a function of the package if possible.

@katy-sadowski
Copy link
Collaborator

Hey @edward-burn - that code you mention has now been added in a vignette here (see code starting at # Get results)

@jshoughtaling
Copy link
Contributor

Hey @edward-burn and @katy-sadowski - I opened PR #497 yesterday that addresses this issue and adds a public function + tests in line with the vignette linked above.

@katy-sadowski katy-sadowski moved this from Todo to In Progress in HADES Hack-a-thon Oct 21, 2023
@katy-sadowski katy-sadowski moved this from In Progress to PR ready for review in HADES Hack-a-thon Oct 21, 2023
@katy-sadowski katy-sadowski moved this from PR ready for review to Merged into develop branch in HADES Hack-a-thon Oct 21, 2023
@katy-sadowski
Copy link
Collaborator

This is added in v2.5! Thanks @jshoughtaling !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants