Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test warnings / silent writeToTable failure #438

Open
katy-sadowski opened this issue Apr 15, 2023 · 2 comments
Open

Unit test warnings / silent writeToTable failure #438

katy-sadowski opened this issue Apr 15, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@katy-sadowski
Copy link
Collaborator

katy-sadowski commented Apr 15, 2023

Error in testthat tests:

Writing table failed: Columns `cdm_field_name`, `concept_id`, `unit_concept_id`, `subcategory`, `warning`, `error`, `not_applicable_reason`, `notes_value` not found

This is strange, as these columns are definitely included in the DDL. We need to investigate what's going on.

This was silently failing in our unit tests because the write to table step is wrapped in a try/catch. So the unit test should also be updated to expect no logged error.

@katy-sadowski katy-sadowski added the bug Something isn't working label Apr 15, 2023
@katy-sadowski katy-sadowski self-assigned this Apr 15, 2023
@katy-sadowski
Copy link
Collaborator Author

We're also getting this warning on write to table tests; should look into this as well: Column 'warning' is of type 'logical', but this is not supported by many DBMSs. Converting to numeric (1 = TRUE, 0 = FALSE)

@katy-sadowski
Copy link
Collaborator Author

Write to table failure was occurring because test files are run in parallel, and we were getting collisions between different tests using the same results DB table. Fixed this in #502. Still TODO:

  • Don't let writeToTable fail silently (should at the very least throw a warning)
  • Fix logical type warning mentioned in comment above

@katy-sadowski katy-sadowski changed the title writeToTable option failing Unit test warnings / silent writeToTable failure Dec 2, 2023
@github-project-automation github-project-automation bot moved this to In Progress in Version 2.X Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

No branches or pull requests

1 participant