Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing standardConceptFieldName in some sourceValueCompleteness rows #560

Open
katy-sadowski opened this issue Jul 15, 2024 · 0 comments
Open
Labels
bug Something isn't working Good first issue

Comments

@katy-sadowski
Copy link
Collaborator

katy-sadowski commented Jul 15, 2024

We cleaned up the thresholds for this check in the latest release, and forgot to populate standardConceptFieldName for a few fields where a threshold was newly added. This causes a SQL error for those checks.

Specifically those fields are:

VISIT_OCCURRENCE.ADMITTED_FROM_SOURCE_VALUE --> standardConceptFieldName should be ADMITTED_FROM_CONCEPT_ID
VISIT_OCCURRENCE.DISCHARGED_TO_SOURCE_VALUE --> standardConceptFieldName should be DISCHARGED_TO_CONCEPT_ID
VISIT_DETAIL.ADMITTED_FROM_SOURCE_VALUE --> standardConceptFieldName should be ADMITTED_FROM_CONCEPT_ID
VISIT_DETAIL.DISCHARGED_TO_SOURCE_VALUE --> standardConceptFieldName should be DISCHARGED_TO_CONCEPT_ID

I know this is an issue in the v5.4 field-level threshold file. The corresponding fields (which have slightly different names) should be checked in v5.3 as well. I don't think these fields existed in v5.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Good first issue
Projects
None yet
Development

No branches or pull requests

1 participant