Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'meas value' domain restriction #580

Closed
clairblacketer opened this issue Dec 4, 2024 · 1 comment
Closed

Remove 'meas value' domain restriction #580

clairblacketer opened this issue Dec 4, 2024 · 1 comment
Assignees
@katy-sadowski
Labels
check bug/enhancement DQ check SQL logic has a bug or needs refinement

Comments

@clairblacketer
Copy link
Collaborator

For measurement.value_as_concept_id we require that the domain is 'meas value'. However, there are some 'Maps to Value' relationships that do not map to 'meas value' concepts. We should remove this restriction given that it is not reflected in the vocabulary.

for reference: OHDSI/CommonDataModel#598
@katy-sadowski katy-sadowski added the check bug/enhancement DQ check SQL logic has a bug or needs refinement label Dec 6, 2024
@katy-sadowski katy-sadowski self-assigned this Dec 21, 2024
@katy-sadowski katy-sadowski mentioned this issue Dec 21, 2024
Merged
@katy-sadowski katy-sadowski moved this to Done in Version 2.X Dec 22, 2024
@katy-sadowski
Copy link
Collaborator

This was fixed in release 2.6.2 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katy-sadowski katy-sadowski

Labels
check bug/enhancement DQ check SQL logic has a bug or needs refinement
Projects
Version 2.X
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clairblacketer @katy-sadowski