Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADES versioning for repository & docker container? #37

Open
anthonysena opened this issue Apr 15, 2024 · 2 comments
Open

HADES versioning for repository & docker container? #37

anthonysena opened this issue Apr 15, 2024 · 2 comments

Comments

@anthonysena
Copy link

Hi - just wanted to raise this question as I was unclear on how we want to approach versioning for this repository & for the corresponding HADES docker container. Looking at the NEWS.md it looks like the HADES version is incremented as new packages are added to HADES.

Then we have the HADES wide releases which are every 6 months and are versioned by date (2024Q1). Do we want to aim to have a container release for each HADES wide lock file? I'm assuming 'yes' but wanted to get some input from @schuemie @leeevans @konstjar

The containers would then reside here: https://hub.docker.com/r/ohdsi/broadsea-hades/tags and tagged as ohdsi/broadsea-hades:2024q1 for the 2024Q1 release.

@schuemie
Copy link
Member

Yes, currently this repo has a several functions:

  1. It holds the Hades R package, which currently has no code but depends on all HADES packages and therefore, if you install the Hades package you install all of HADES. I change the version of this R package whenever a HADES package is added or removed.
  2. It holds the HADES website.
  3. It holds the HADES-wide releases (renv lock files).

I thing aligning Docker containers with HADES-wide releases makes sense.

@anthonysena
Copy link
Author

Excellent thanks @schuemie - I'll work to get this set up with @leeevans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants