Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different ways to select databases - please standardize #296

Closed
jswerdel opened this issue Jun 20, 2024 · 1 comment
Closed

Different ways to select databases - please standardize #296

jswerdel opened this issue Jun 20, 2024 · 1 comment

Comments

@jswerdel
Copy link

jswerdel commented Jun 20, 2024

To select databases to view in Cohort Incidence you have a dropdown list with select all/deselect all. In some of the new modules it selects from a list and builds a list of databases. It would be nice to standardize the approach.

nhall6 added a commit that referenced this issue Aug 27, 2024
Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases
@nhall6
Copy link
Collaborator

nhall6 commented Aug 27, 2024

@jswerdel this has been fixed in #327

@nhall6 nhall6 closed this as completed Aug 27, 2024
jreps pushed a commit that referenced this issue Sep 12, 2024
Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases
jreps added a commit that referenced this issue Sep 19, 2024
* Fixing #301 (#326)

Adding alphabetical sort to DB input options

* Fixing #296 (#327)

Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases

* Fixing #302 and Filtered Data Downloads (#332)

* Fixing #302 and Filtered Data Downloads

All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte

* Updating the fix

Also fixed download buttons in Cohorts module, addressing #298

* Update R_CMD_check_Hades.yaml

* Update R_CMD_check_Hades.yaml

* Update R_CMD_check_Hades.yaml

* fixing R checks

fixing R checks

* Update cohort-diagnostics-databaseInformation.R (#333)

Fixing the issue reported in #162

* fixing issue issue_330 (#334)

fixing time plot x-axis

* fixing issue 167 (#335)

added code to get long database names on multiple lines

* Update cohort-diagnostics-timeDistributions.R (#336)

adding fix for issue 168

* Update patient-level-prediction-modelSummary.R (#337)

---------

Co-authored-by: Nathan Hall <[email protected]>
jreps added a commit that referenced this issue Sep 20, 2024
* Fixing Power tables re: #114

Standardizing power table outputs to adhere to OSM standard theme (reactable via resultTableViewer and resultTableServer). Also split the tables into 2 sub-tabs for easier readability

* Updating propensity score table

Adding conditional formatting of colors to values to aid in interpretation, and also adding an absolute value of beta column.

* Updates to propensity score plot

Overlaying equipoise statistic onto the plot, and truncating cohort names in legend

* Updating covariate balance plot

Adding maxSDM to covariate balance plot

* Updating  captions and systematic error

Adding to caption descriptions in figures and overlaying EASE statistic on systematic error plot

* Updating systematic error

Adding more descriptive filenames for plot downloads

* Develop (#340)

* Fixing #301 (#326)

Adding alphabetical sort to DB input options

* Fixing #296 (#327)

Standardizing pickerInput type for database selection where multiple options are possible to improve UX. Also fixed some colDefs in Exposed Cases

* Fixing #302 and Filtered Data Downloads (#332)

* Fixing #302 and Filtered Data Downloads

All filtered data downloads across all modules should work now, with a button styled the same as the full download. It needs to be a CSV handler though due to the reactable statte

* Updating the fix

Also fixed download buttons in Cohorts module, addressing #298

* Update R_CMD_check_Hades.yaml

* Update R_CMD_check_Hades.yaml

* Update R_CMD_check_Hades.yaml

* fixing R checks

fixing R checks

* Update cohort-diagnostics-databaseInformation.R (#333)

Fixing the issue reported in #162

* fixing issue issue_330 (#334)

fixing time plot x-axis

* fixing issue 167 (#335)

added code to get long database names on multiple lines

* Update cohort-diagnostics-timeDistributions.R (#336)

adding fix for issue 168

* Update patient-level-prediction-modelSummary.R (#337)

---------

Co-authored-by: Nathan Hall <[email protected]>

* fixing testing errors

---------

Co-authored-by: jreps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants