Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak to presentation of small cells (i.e. < min threshold) in Database Comparison interface #325

Open
conovermitch opened this issue Aug 22, 2024 · 1 comment
Labels
Characterization enhancement New feature or request

Comments

@conovermitch
Copy link

conovermitch commented Aug 22, 2024

Issue: Note this is a low-urgency suggestion to change output formatting, noting some confusion users are having with the system. Nothing is incorrect but I will describe why re-thinking/standardizing some formatting practices may be beneficial for some users. The Covariate Threshold feature within the Database Comparison interface is being misinterpreted by users. Users of the dashboard interpret the "< min threshold" to mean N<5. However, it actually reflects that the percentage column is below the Covariate Threshold set using the slider interface. This can be confusing for a number of reasons: 1) When the Covariate Threshold slider is set to 0 the minimum threshold applied to the table still appears to be 1%. Ideally, the user would not have the option of selecting thresholds below the minimum possible threshold. 2) The "<min threshold" dialog only appears when there is some cell with populated contents. In instances where all columns are "<min threshold" for a given row the entire row is censored from the data. 3) The table can show counts <5 as long as the "min threshold" (which is on the proportion scale) has been met.

Please note that all of this behavior is different from the corresponding functionality in the Incidence Rate Table which appears to use the notation "-5" when a cell count is less than 5. I'm not necessarily implying that the functionality should be the same for the two tables but I do think some of the ambiguity results in misinterpretation of the data.

Location of issue: Characterization module --> Cohort Summary --> Database Comparison --> Covariate Threshold

Package Versions: Generated with OhdsiShinyModules v2.1.5.9000 and ShinyAppBuilder v2.0.1.9000

@conovermitch conovermitch changed the title Tweak to presentation of results Tweak to presentation of small cells (i.e. < min threshold) in Database Comparison interface Aug 22, 2024
@jreps
Copy link
Collaborator

jreps commented Aug 22, 2024

Yeah - this is also linked to the FE setting that specifies minimum frequency. I have that easy to access so should be able to edit the column to have < a value rather than < min threshold. Will add this as an improvement to make.

@jreps jreps added Characterization enhancement New feature or request labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Characterization enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants