You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Below picture is the sample of Authorship description in english.
created by ohdsi on 2024-02-08 8:46
In korean, the description must be as below.
ohdsi가 2024-02-08 8:46에 생성
Actual behavior
But, currently the description is very strange to korean since the sentence order is not proper.
만들어진 by ohdsi ~에 2024-02-08 8:46
Steps to reproduce behavior
You may change the language as below.
Solution
To solve this problem, I added createdEnd and modifiedEnd to the components.authorship entry in the i18n/messages_ko.json file.
I think this is the only method of choice because the order of sentences in Korean is different.
And In Atlas UI, the authorship.html must be changed to use the added createdEnd and modifiedEnd.
I already change both source WebAPI and Atlas, then test was done in my local environment.
I will commit the changes to both WebAPI and Atlas.
The text was updated successfully, but these errors were encountered:
Expected behavior
Below picture is the sample of Authorship description in english.
created by ohdsi on 2024-02-08 8:46
In korean, the description must be as below.
ohdsi가 2024-02-08 8:46에 생성
Actual behavior
But, currently the description is very strange to korean since the sentence order is not proper.
만들어진 by ohdsi ~에 2024-02-08 8:46
Steps to reproduce behavior
You may change the language as below.
Solution
To solve this problem, I added createdEnd and modifiedEnd to the components.authorship entry in the i18n/messages_ko.json file.
I think this is the only method of choice because the order of sentences in Korean is different.
And In Atlas UI, the authorship.html must be changed to use the added createdEnd and modifiedEnd.
I already change both source WebAPI and Atlas, then test was done in my local environment.
I will commit the changes to both WebAPI and Atlas.
The text was updated successfully, but these errors were encountered: