Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Korean sentence order in Authorship description is incorrect. #2381

Open
tandara0 opened this issue Jul 31, 2024 · 0 comments
Open

The Korean sentence order in Authorship description is incorrect. #2381

tandara0 opened this issue Jul 31, 2024 · 0 comments

Comments

@tandara0
Copy link
Contributor

tandara0 commented Jul 31, 2024

Expected behavior

Below picture is the sample of Authorship description in english.

created by ohdsi on 2024-02-08 8:46
image

In korean, the description must be as below.

ohdsi가 2024-02-08 8:46에 생성
image

Actual behavior

But, currently the description is very strange to korean since the sentence order is not proper.

만들어진 by ohdsi ~에 2024-02-08 8:46
image

Steps to reproduce behavior

You may change the language as below.
image

Solution

To solve this problem, I added createdEnd and modifiedEnd to the components.authorship entry in the i18n/messages_ko.json file.
I think this is the only method of choice because the order of sentences in Korean is different.
And In Atlas UI, the authorship.html must be changed to use the added createdEnd and modifiedEnd.

I already change both source WebAPI and Atlas, then test was done in my local environment.
I will commit the changes to both WebAPI and Atlas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant