Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IRIS support to WebAPI #2409

Open
anthonysena opened this issue Nov 12, 2024 · 7 comments · May be fixed by #2416
Open

Add IRIS support to WebAPI #2409

anthonysena opened this issue Nov 12, 2024 · 7 comments · May be fixed by #2416
Milestone

Comments

@anthonysena
Copy link
Collaborator

Based on the work done to support IRIS in SqlRender v1.19, we'd like to add the necessary changes to WebAPI to carry these changes through for Atlas.

One question related to this change: are there any restriction on the number of items in the IN clause? This came up in #2284 and we'd like to confirm this.

@bdeboe @alex-odysseus

@anthonysena anthonysena added this to the v2.15 milestone Nov 12, 2024
@bdeboe
Copy link

bdeboe commented Nov 12, 2024

Hi @anthonysena ,

we have a fork of this repository available at https://github.com/intersystems-community/OHDSI-WebAPI, but need to first get the one for https://github.com/intersystems-community/OHDSI-DatabaseConnector into the regular OHDSI repository. That work is all ready to submit, but requires that we also make a test server available for OHDSI team members to validate the work. Unfortunately, we're hitting a cluster of red tape internally, with the test server requiring an OS for which our current license provider's contract had to be replaced etc etc :-(
These contracting issues could / should be addressed any day now, so hopefully this won't take much longer.

The repositories referenced above should allow you to get a working version together. If not, please do reach out and we'd be happy to assist!

Thanks,
benjamin

@anthonysena
Copy link
Collaborator Author

Thanks for this update @bdeboe. In speaking with @alex-odysseus they are working on making the changes to WebAPI and these references will be helpful.

I didn't go through the code but did you have to make changes to support any limit in the IN clause as I mentioned earlier in this issue?

@bdeboe
Copy link

bdeboe commented Nov 13, 2024

Not sure whether you're asking @alex-odysseus wrt Snowflake, but as far as InterSystems IRIS is concerned we do have a hard limit around 32k, which should be OK given the getParameterLimit() implementation you referenced in #2284 .

@anthonysena
Copy link
Collaborator Author

Thanks @bdeboe I was asking this of you since @alex-odysseus mentioned they were working on adding the IRIS support and we were unsure of this limit. I think we can treat it the same way we are with Google BigQuery and Snowflake. Thanks!

@alex-odysseus
Copy link
Contributor

Martijn, please support in releasing SqlRender 1.19.1 at your convenience which will contain some of the necessary replacement patterns for InterSystems IRIS as we are willing to have the new dialect support in the upcoming WebAPI 2.15.0 release @schuemie

Thank you, Alex

@alex-odysseus
Copy link
Contributor

Benjamin, please create pull requests for WebAPI and ATLAS as ARACHNE Commons 1.17.4 should be available @bdeboe

@bdeboe bdeboe linked a pull request Dec 4, 2024 that will close this issue
@bdeboe
Copy link

bdeboe commented Dec 4, 2024

Done. I had not realized the ArachneCommons library was on Maven already, as the GH repo still lists 1.17.3. Thanks for pushing that @alex-odysseus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants