Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(colorlut): use the correct colorlut index and update vtk #4544

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Nov 22, 2024

Updating Cornerstone3D for the segmentation color changes which fixes #4499

and also vtk.js which most likely fixes this one #4286

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit eb7162a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6740e2060ab6fe0008717e67
😎 Deploy Preview https://deploy-preview-4544--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit eb7162a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6740e2062d2720000854bf8c
😎 Deploy Preview https://deploy-preview-4544--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi November 22, 2024 16:53
@sedghi sedghi changed the title fix(colorlut): use the correct colorlut index if there's multiple segmentations fix(colorlut): use the correct colorlut index and update vtk Nov 22, 2024
Copy link

cypress bot commented Nov 22, 2024

Viewers    Run #4464

Run Properties:  status check failed Failed #4464  •  git commit eb7162aaa0: Merge branch 'master' of github.com:OHIF/Viewers into OHI-1306
Project Viewers
Branch Review OHI-1306
Run status status check failed Failed #4464
Run duration 02m 09s
Commit git commit eb7162aaa0: Merge branch 'master' of github.com:OHIF/Viewers into OHI-1306
Committer sedghi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 3
Tests that passed  Passing 40
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/integration/measurement-tracking/OHIFStudyBrowser.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study Browser > checks if series thumbnails are being displayed Test Replay Screenshots Video

@sedghi sedghi merged commit b9c26e7 into master Nov 22, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] modality=SEG colors not displayed properly when there are two .dcm files
2 participants