-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(colorlut): use the correct colorlut index and update vtk #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
changed the title
fix(colorlut): use the correct colorlut index if there's multiple segmentations
fix(colorlut): use the correct colorlut index and update vtk
Nov 22, 2024
sedghi
approved these changes
Nov 22, 2024
sedghi
approved these changes
Nov 22, 2024
Viewers Run #4464
Run Properties:
|
Project |
Viewers
|
Branch Review |
OHI-1306
|
Run status |
Failed #4464
|
Run duration | 02m 09s |
Commit |
eb7162aaa0: Merge branch 'master' of github.com:OHIF/Viewers into OHI-1306
|
Committer | sedghi |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
2
|
Skipped |
3
|
Passing |
40
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/integration/measurement-tracking/OHIFStudyBrowser.spec.js • 1 failed test
Test | Artifacts | |
---|---|---|
OHIF Study Browser > checks if series thumbnails are being displayed |
Test Replay
Screenshots
Video
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Cornerstone3D for the segmentation color changes which fixes #4499
and also vtk.js which most likely fixes this one #4286