Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: Range measurements #4820

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

wayfarer3130
Copy link
Contributor

Context

Add context menu fixes to address a number of range measurement settings

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 541ab2f
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67c22cccf501ad000806da56
😎 Deploy Preview https://deploy-preview-4820--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 541ab2f
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67c22ccc835c460008766961
😎 Deploy Preview https://deploy-preview-4820--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Feb 28, 2025

Viewers    Run #4869

Run Properties:  status check failed Failed #4869  •  git commit 541ab2f354: fix: Show dialog properly
Project Viewers
Branch Review fix/range-measurements
Run status status check failed Failed #4869
Run duration 02m 11s
Commit git commit 541ab2f354: fix: Show dialog properly
Committer Bill Wallace
View all properties for this run ↗︎

Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 42
View all changes introduced in this branch ↗︎

Tests for review

Failed  volume/MPR.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF MPR > should correctly render Crosshairs for MPR Test Replay Screenshots Video
Failed  measurement-tracking/OHIFDownloadSnapshotFile.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Download Snapshot File > checks displayed information for Desktop experience Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant