Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OHI-1681] feat(fonts): bundle fonts in OHIF and dont use google cdn #4821

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IbrahimCSAE
Copy link
Collaborator

@IbrahimCSAE IbrahimCSAE commented Feb 28, 2025

Context

Bundling fonts

Fixes #4805

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 515d10d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67c29202471ff900087ff2a3

Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 515d10d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67c2920255545c0008e31f47
😎 Deploy Preview https://deploy-preview-4821--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IbrahimCSAE IbrahimCSAE requested a review from sedghi February 28, 2025 18:40
@IbrahimCSAE IbrahimCSAE changed the title feat(fonts): bundle fonts in OHIF and dont use google cdn [OHI-1681] feat(fonts): bundle fonts in OHIF and dont use google cdn Feb 28, 2025
Copy link

cypress bot commented Feb 28, 2025

Viewers    Run #4870

Run Properties:  status check failed Failed #4870  •  git commit 515d10d12d: remove useless fonts
Project Viewers
Branch Review feat/bundle-font
Run status status check failed Failed #4870
Run duration 02m 03s
Commit git commit 515d10d12d: remove useless fonts
Committer Ibrahim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 43
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/integration/volume/MPR.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF MPR > should correctly render Crosshairs for MPR Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] With or Without Google fonts
1 participant