fix: remove textarea autofocus #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
那点击段落右边的评论按钮，还有自动 focus 不 |
|
也没有了。理论上好像是应该区分一下？ |
|
不过我看代码的时候看到个有点奇怪的东西，这里是不是应该是 |
|
尝试阅读了一下现在的代码，确实是有 @shaokeyibb 提到的判定的，如果是点击 paragraph 的话， focusReply 应该是会是 false 的 |
Enter-tainer
force-pushed
the
mgt/remove-focus
branch
from
8778b9c to
4349df5
Compare
Enter-tainer
commented
Sep 28, 2024
|
改成 && 我理解肯定是不对的🤔，这里感觉应该还是额外做一下特判才对 |
我理解了一下这里的逻辑，似乎是说，如果有 comments，或者是强制指定了要 focus 过去（对应点击按钮的情况），那么打开边栏并 focus textarea 这里的逻辑大概是这样的，分几种情况：
实际上我们希望对于 2，不要 focus textarea |
Enter-tainer
force-pushed
the
mgt/remove-focus
branch
2 times, most recently
from
fd9901c to
e6ba21e
Compare
Enter-tainer
force-pushed
the
mgt/remove-focus
branch
from
e6ba21e to
a9b626e
Compare
|
我改好了，但是我发现现在在本地好像根本没办法测试了（因为 github 登陆啥的好像不太work），或许 @shaokeyibb 可以有空导一份线上的数据，也可以用来进行本地的测试.. |
|
（或者有没有更科学的测试的方法推荐 |
|
本地测试 work 的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #103
现在每次点击被评论的段落时，焦点会被移动到textarea里面，导致丢失选择的区间，没法复制内容，现在把这个关掉了
cc @ikkz