Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pending for submit & modify submit is not correctly displayed #118

Closed
wants to merge 1 commit into from
Closed

fix: pending for submit & modify submit is not correctly displayed #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions frontend/lib/dom/comment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export const submitComment = async ({
pending: true,
});
}

await openCommentsPanel();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不太好吧...在这种网络请求的函数做这种更改UI的调用会不会有点过耦合了

const resp = await res;

if (!resp.ok) {
Expand All @@ -263,7 +263,7 @@ export const submitComment = async ({
updateAvailableComments();
};

export const _modifyComment = async ({
export const modifyComment = async ({
id,
comment,
}: {
Expand All @@ -290,6 +290,7 @@ export const _modifyComment = async ({
);
}

await openCommentsPanel();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也是

const resp = await res;

if (!resp.ok) {
Expand Down Expand Up @@ -714,7 +715,6 @@ export const renderComments = async (comments: Comment[]) => {
}

notification.textContent = "";
await openCommentsPanel();
const newSubmitButton = commentsPanel.querySelector(
"[data-review-selected] button[data-action='submit']",
) as HTMLButtonElement;
Expand Down Expand Up @@ -805,10 +805,9 @@ export const renderComments = async (comments: Comment[]) => {
case "modify_submit": {
const id = container.dataset.modifingId;
if (id == undefined) return;
await openCommentsPanel();

try {
await _modifyComment({
await modifyComment({
id: parseInt(id),
comment: textarea.value,
});
Expand Down