-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual layering styling #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rounded and shadowed comment panel - Muted footer text
shaokeyibb
reviewed
Oct 6, 2024
另外移动端评论面板的这个圆角会不会有点丑( |
移动端只在左边加圆角是觉得动画是从右边拉出来的然后两边圆角的话就有点怪 🤔 |
我的意思是,这个圆角和视口边界加起来有点怪怪的。但是也不是非得改,如果你觉得这样就好那就这样 |
+1,这个看起来有点怪怪的 |
那感觉移动端还是关掉圆角好了 |
Enter-tainer
reviewed
Oct 6, 2024
Enter-tainer
approved these changes
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Light mode
Desktop
Old
New
Mobile
Old
New
Dark Mode
By adding
review_dark_mode_class
Desktop
New (combined w/ Snipaste)
Old
Mobile
New
Old
Highlight bar
Emulated with devtool
Desktop
New
Old
Mobile
New
Old
Thx