Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual layering styling #137

Merged
merged 5 commits into from
Oct 6, 2024
Merged

Conversation

ksyx
Copy link
Member

@ksyx ksyx commented Oct 6, 2024

  • Rounded and shadowed comment panel
  • Muted footer text

Light mode

Desktop

Old
image
New
image

Mobile

Old

New
image

Dark Mode

By adding review_dark_mode_class

Desktop

New (combined w/ Snipaste)
image
Old
image

Mobile

New
image
Old
image

Highlight bar

Emulated with devtool

Desktop

New
image
image
Old
image
image

Mobile

New
image
image
Old
image
image

Thx

frontend/lib/style.css Outdated Show resolved Hide resolved
@shaokeyibb
Copy link
Member

另外移动端评论面板的这个圆角会不会有点丑(

@ksyx
Copy link
Member Author

ksyx commented Oct 6, 2024

移动端只在左边加圆角是觉得动画是从右边拉出来的然后两边圆角的话就有点怪 🤔

@shaokeyibb
Copy link
Member

移动端只在左边加圆角是觉得动画是从右边拉出来的然后两边圆角的话就有点怪 🤔

我的意思是,这个圆角和视口边界加起来有点怪怪的。但是也不是非得改,如果你觉得这样就好那就这样

@Enter-tainer
Copy link
Member

另外移动端评论面板的这个圆角会不会有点丑(

+1,这个看起来有点怪怪的

@ksyx
Copy link
Member Author

ksyx commented Oct 6, 2024

那感觉移动端还是关掉圆角好了

Copy link
Member

@Enter-tainer Enter-tainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@Enter-tainer Enter-tainer merged commit e367246 into OI-wiki:master Oct 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants