lzma: realloc dictionary only to extend it

Otherwise, we can spend much time in useless reallocs which do not increase the siez of lzma dictionary.
OISF · Apr 16, 2022 · 32216ff · 32216ff
1 parent 80f6c40
commit 32216ff
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/htp/lzma/LzmaDec.c b/htp/lzma/LzmaDec.c
@@ -634,15 +634,15 @@ static int MY_FAST_CALL LzmaDec_DecodeReal2(CLzmaDec *p, SizeT limit, const Byte
       if (limit - p->dicPos > rem) {
           if (p->dicBufSize < p->prop.dicSize) {
               p->dicBufSize = p->prop.dicSize;
+              if (p->dicBufSize > memlimit) {
+                  return SZ_ERROR_MEM;
+              }
+              Byte *tmp = realloc(p->dic, p->dicBufSize);
+              if (!tmp) {
+                  return SZ_ERROR_MEM;
+              }
+              p->dic = tmp;
           }
-          if (p->dicBufSize > memlimit) {
-              return SZ_ERROR_MEM;
-          }
-          Byte *tmp = realloc(p->dic, p->dicBufSize);
-          if (!tmp) {
-              return SZ_ERROR_MEM;
-          }
-          p->dic = tmp;
         limit2 = p->dicPos + rem;
         }