prefilter/multibuf: test with multiple packets #2094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catenacyber
added
the
requires suricata fix
catenacyber
force-pushed
the
multibuf-prefilter-7326-v1
branch
from
225a6bd
to
72f6d13
Compare
catenacyber
added
requires suricata pr
jufajardini
reviewed
Oct 15, 2024
Comment on lines
+7
to
+8
| checks: | ||
| - filter: |
There was a problem hiding this comment.
Is sid: 1 not expected to match? If so, should we include a check to assert that?
There was a problem hiding this comment.
sid 1 was a leftover from #2093 where I found this bug
catenacyber
force-pushed
the
multibuf-prefilter-7326-v1
branch
from
72f6d13
to
a05a1ee
Compare
catenacyber
force-pushed
the
multibuf-prefilter-7326-v1
branch
from
a05a1ee
to
32f0153
Compare
victorjulien
approved these changes
Nov 4, 2024
|
Not sure why, but this fails on my openbsd runner. |
|
ah |
Ticket: 7326
catenacyber
force-pushed
the
multibuf-prefilter-7326-v1
branch
from
32f0153
to
3398948
Compare
|
Force-pushed the pcap resaved with my Wireshark Before : |
|
Merged in #2118, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: 7326
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7326