Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect/integers: test enum with negated strings - v3 #2271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

detect/integers: test enum with negated strings - v3 #2271

wants to merge 1 commit into from

Conversation

AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Jan 31, 2025 •
edited
Loading

Ticket: #7513

Description:

  • add test to check enum with negated strings

Changes:

  • add checks for event_type: alert: line 18, line 25
  • add check for rule that should not alert: line 32
  • use !text instead of !pong: line 1
  • add rule that should not alert: line 5

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7513

Suricata PR: OISF/suricata#12516
Previous PR: #2257

This was referenced Jan 31, 2025
Closed
Open
catenacyber
catenacyber approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good for the functionality that we want

@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Feb 5, 2025
@victorjulien victorjulien mentioned this pull request Feb 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

@catenacyber catenacyber catenacyber approved these changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AkakiAlice @victorjulien @catenacyber