Warnint 64to32 6186 v23.3 #11904
Closed
Warnint 64to32 6186 v23.3 #11904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7311 If response_status_number is not a valid poisitive integer, we should not try to parse it again, and fail again, but just log the raw string.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11904 +/- ##
==========================================
+ Coverage 82.60% 82.62% +0.02%
==========================================
Files 912 912
Lines 249342 249333 -9
==========================================
+ Hits 205968 206012 +44
+ Misses 43374 43321 -53
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 23061 |
|
Please split the http logging change into it's own commit. It needs to be discussed as a feature, not as part of a series of compiler warning fixups. |
It is in its own commit, but I guessed you meant its own PR, so : #11952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6186
https://redmine.openinfosecfoundation.org/issues/7311
Describe changes:
-Wshorten-64-to-32warnings for some files : output, streamSome commits of #9840
#11580 next batch
#11705 with code review taken into account
Still to do afterwards :
SV_BRANCH=OISF/suricata-verify#2085