Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform rust 7229 v6 #12054

Closed
wants to merge 5 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7229
https://redmine.openinfosecfoundation.org/issues/7352

Describe changes:

  • transforms: move strip_whitespace and compress_whitespace and dot_prefix to rust
  • remove disable-hashing command line option

Should we do all transforms ?

#11934 with hashes transforms moved to rust as well

Benchmark
./src/suricata -r bigf.pcapng -S bigf.rules -c bigf.yaml -k none -l log --runmode single
with big.rules being alert tcp any any -> any any (file.data; strip_whitespace; content:"hasxspace"; sid:1;) and bigf.pcapng being a capture of http1 download of 28 Mbyte file SV datasets-1m-StringSets/datasets.csv and bigf.yaml having all kinds of options for profiling

with PR

  Date: 10/10/2024 -- 11:10:46
  --------------------------------------------------------------------------------------------------------------------------------
  Stats for: total
  --------------------------------------------------------------------------------------------------------------------------------
  Prefilter                        Ticks           Called          Max Ticks       Avg             Bytes           Called          Max Bytes       Avg Bytes       Ticks/Byte     
  -------------------------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- 
  file_data#179 (strip_whitespace  77389980        119             2075940         650335.00       28534678        116             266949          245988.00       2.00      

With master

  Stats for: total
  --------------------------------------------------------------------------------------------------------------------------------
  Prefilter                        Ticks           Called          Max Ticks       Avg             Bytes           Called          Max Bytes       Avg Bytes       Ticks/Byte     
  -------------------------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- --------------- 
  file_data#179 (strip_whitespace  81533120        119             1905360         685152.00       28499770        116             266647          245687.00       2.00           

So 77389980 vs 81533120 does not seem significant for a difference

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 83.79747% with 64 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (3a7eef8) to head (cdb53f9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12054      +/-   ##
==========================================
- Coverage   83.42%   79.77%   -3.66%     
==========================================
  Files         910      908       -2     
  Lines      257642   257397     -245     
==========================================
- Hits       214949   205346    -9603     
- Misses      42693    52051    +9358     
Flag Coverage Δ
fuzzcorpus 61.55% <77.37%> (-0.10%) ⬇️
livemode 19.41% <33.77%> (+<0.01%) ⬆️
pcap 44.45% <45.24%> (-0.04%) ⬇️
suricata-verify ?
unittests 59.31% <60.25%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber
Copy link
Contributor Author

Next in #12061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant