Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0.x: backport of rust ffi fix - v1 #12059

Merged
merged 2 commits into from
Oct 30, 2024
Merged

7.0.x: backport of rust ffi fix - v1 #12059

merged 2 commits into from
Oct 30, 2024

Conversation

jasonish
Copy link
Member

@jasonish
eve/schema: add missing field "code" anomaly events
10225bd 
(cherry picked from commit b44fc62)
@jasonish
rust/applayer: use c_int as return type for get_info_by_id
3000e96 
Rust was using i8 as the return type, while C uses int. As of Rust
1.82, the return value is turned to garbage over the FFI boundary.

Ticket: OISF#7338
(cherry picked from commit 45384ef)
@jasonish jasonish requested review from victorjulien and a team as code owners October 29, 2024 15:47
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (ede115f) to head (3000e96).
Report is 2 commits behind head on main-7.0.x.

Additional details and impacted files 
@@              Coverage Diff               @@
##           main-7.0.x   #12059      +/-   ##
==============================================
+ Coverage       83.40%   83.42%   +0.01%     
==============================================
  Files             922      922              
  Lines          260795   260795              
==============================================
+ Hits           217526   217558      +32     
+ Misses          43269    43237      -32
Flag Coverage Δ
fuzzcorpus 64.78% <100.00%> (+0.02%) ⬆️
suricata-verify 63.34% <100.00%> (+0.02%) ⬆️
unittests 62.38% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23202

@victorjulien victorjulien mentioned this pull request Oct 30, 2024
Merged
@victorjulien victorjulien merged commit 3000e96 into OISF:main-7.0.x Oct 30, 2024
88 checks passed
@victorjulien
Copy link
Member

Merged in #12067, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonish @suricata-qa @victorjulien