-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Radix/v7 #12064
Open
victorjulien
wants to merge
12
commits into
OISF:master
Choose a base branch
from
victorjulien:radix/v7
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Radix/v7 #12064
+3,479
−4,648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a more compact set of trees specifically for IPv4 and IPv6 addresses. This allows for more compact data structures and fewer memory allocations. Based on the existing radix tree implementation.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Use a more compact ipv4 specific structure.
Use a more compact ipv6 specific structure.
No longer used.
Rename types enum to reflect it is not using a radix tree anymore.
Move repeated pattern into helper function.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12064 +/- ##
==========================================
- Coverage 83.42% 83.42% -0.01%
==========================================
Files 910 913 +3
Lines 257642 256642 -1000
==========================================
- Hits 214949 214109 -840
+ Misses 42693 42533 -160
Flags with carried forward coverage won't be shown. Click here to find out more. |
Information: QA ran without warnings. Pipeline 23211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase and cleanup of a branch I did a few years ago.
Reimplement radix tree as 2 specific implementations: one for ipv4 and one for ipv6. Update all users and remove old implementation.
Just cleanups, no ticket.