Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radix/v7 #12064

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Radix/v7 #12064

wants to merge 12 commits into from

Conversation

victorjulien
Copy link
Member

Rebase and cleanup of a branch I did a few years ago.

Reimplement radix tree as 2 specific implementations: one for ipv4 and one for ipv6. Update all users and remove old implementation.

Just cleanups, no ticket.

Implement a more compact set of trees specifically for IPv4
and IPv6 addresses. This allows for more compact data structures
and fewer memory allocations.

Based on the existing radix tree implementation.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Splits the unified tree into a ipv4 specific and ipv6 specific tree.
Use a more compact ipv4 specific structure.
Use a more compact ipv6 specific structure.
Rename types enum to reflect it is not using a radix tree anymore.
Move repeated pattern into helper function.
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 89.10506% with 196 lines in your changes missing coverage. Please review.

Project coverage is 83.42%. Comparing base (3a7eef8) to head (da2284f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12064      +/-   ##
==========================================
- Coverage   83.42%   83.42%   -0.01%     
==========================================
  Files         910      913       +3     
  Lines      257642   256642    -1000     
==========================================
- Hits       214949   214109     -840     
+ Misses      42693    42533     -160     
Flag Coverage Δ
fuzzcorpus 61.61% <51.38%> (-0.04%) ⬇️
livemode 19.39% <14.78%> (-0.02%) ⬇️
pcap 44.01% <21.70%> (-0.47%) ⬇️
suricata-verify 62.74% <54.25%> (-0.02%) ⬇️
unittests 59.28% <88.49%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23211

@inashivb inashivb self-requested a review November 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants