-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow timeout timing/v14 #12084
base: master
Are you sure you want to change the base?
Flow timeout timing/v14 #12084
Commits on Nov 3, 2024
-
threads: include name in error message
When a thread fails to spawn, include the thread name in the error message.
Configuration menu - View commit details
-
Copy full SHA for cf4a3cf - Browse repository at this point
Copy the full SHA cf4a3cfView commit details -
unix/socket: cleanup start up logic
No longer init then deinit part of the engine at startup of the unix socket mode.
Configuration menu - View commit details
-
Copy full SHA for 8f3c6bd - Browse repository at this point
Copy the full SHA 8f3c6bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 858453d - Browse repository at this point
Copy the full SHA 858453dView commit details -
flow: improve thread safety during timeout checks
Timeout checks would access certain fields w/o locking, which could lead to thread safety issues.
Configuration menu - View commit details
-
Copy full SHA for 44592ec - Browse repository at this point
Copy the full SHA 44592ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for b1140ea - Browse repository at this point
Copy the full SHA b1140eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c80afe7 - Browse repository at this point
Copy the full SHA c80afe7View commit details -
Use a more precise calculation for timing out flows, using both the seconds and the micro seconds.
Configuration menu - View commit details
-
Copy full SHA for 78b8898 - Browse repository at this point
Copy the full SHA 78b8898View commit details -
time: thread time update after flow update
The flow worker needs to get the opportunity to run the flow update before globally making it's current timestamp available. This is to avoid another thread using the time to evict the flow that is about to get a legitimate update.
Configuration menu - View commit details
-
Copy full SHA for 9bc1c59 - Browse repository at this point
Copy the full SHA 9bc1c59View commit details -
Configuration menu - View commit details
-
Copy full SHA for a516c42 - Browse repository at this point
Copy the full SHA a516c42View commit details -
If seconds match a flow can still be timing out.
Configuration menu - View commit details
-
Copy full SHA for 22683e0 - Browse repository at this point
Copy the full SHA 22683e0View commit details -
flow/worker: improve flow timeout time accuracy
When timing out flows, use the timestamp from the "owning" thread. This avoids problems with threads being out of sync with each other.
Configuration menu - View commit details
-
Copy full SHA for 5411384 - Browse repository at this point
Copy the full SHA 5411384View commit details -
flow/manager: in offline mode, use owning threads time
As this may mean that a threads ts is a bit ahead of the minimum time the flow manager normally uses, it can evict flows a bit faster.
Configuration menu - View commit details
-
Copy full SHA for 663eefc - Browse repository at this point
Copy the full SHA 663eefcView commit details -
Configuration menu - View commit details
-
Copy full SHA for ef672b3 - Browse repository at this point
Copy the full SHA ef672b3View commit details -
threads: seal after setup; unseal at shutdown
The idea of sealing the thread store is that its members can be accessed w/o holding a lock to the whole store at runtime.
Configuration menu - View commit details
-
Copy full SHA for 2b8351f - Browse repository at this point
Copy the full SHA 2b8351fView commit details -
Configuration menu - View commit details
-
Copy full SHA for add7b78 - Browse repository at this point
Copy the full SHA add7b78View commit details
Commits on Nov 4, 2024
-
flow: skip lock for skippable flows
Some checks can be done w/o holding a lock: - seeing if the flow matches the packet - if the hash row needs a timeout check This patch skips taking a lock in these conditions.
Configuration menu - View commit details
-
Copy full SHA for b1ea592 - Browse repository at this point
Copy the full SHA b1ea592View commit details