Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.0.x: fix engine event names; detect error when not found - v1 #12099

Open
wants to merge 5 commits into
base: main-7.0.x
Choose a base branch
from
Open

7.0.x: fix engine event names; detect error when not found - v1 #12099

wants to merge 5 commits into from
+15 −17

Conversation

jasonish
Copy link
Member

@jasonish jasonish commented Nov 7, 2024

Backport of #12079:

  • Additional commit to detect error.

Ticket: Ticket: https://redmine.openinfosecfoundation.org/issues/7361

@jasonish
rust/applayer: return -1 if event info was not found
c1b5d03 
The returned event_id was being set to -1, but the function wasn't
returning -1 to indicate error.

Ticket: OISF#7361
@jasonish
rules/dns: fix dns event names that have changed
0a850e8 
- not_a_request to not_request
- not_a_response to not_reponse

Ticket: OISF#7361
(cherry picked from commit 833c7c6)
@jasonish
rules/ike: fix ike event names that have changed
a92b6bc 
- weak_crypto_nodh -> weak_crypto_no_dh
- weak_crypto_noauth -> weak_crypto_no_auth

Ticket: OISF#7361
(cherry picked from commit b44ba32)
@jasonish
rules/modbus: remove rule for event that not longer exists
af58991 
The event "modbus.invalid_unit_identifier" no longer exists.

Ticket: OISF#7361
(cherry picked from commit a55960e)
@jasonish
http2: rename event variant to match rule
68b631d 
Rename InvalidHTTP1Settings to InvalidHttp1Settings so it gets the
expected name transformation of "invalid_http1_settings".

Ticket: OISF#7361
(cherry picked from commit b1c26dc)
@jasonish jasonish requested review from catenacyber and a team as code owners November 7, 2024 16:02
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 23286

@victorjulien victorjulien mentioned this pull request Nov 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasonish @suricata-qa @victorjulien