Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: Update sawp dependencies to 0.13.1 due to SPDX license compatibility/v2 #12357

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bmbenson
Copy link

@bmbenson bmbenson commented Jan 8, 2025

Previous PR: #12328

Contribution style:

Our Contribution agreements:

Changes (if applicable):

  • [N/A] I have updated the User Guide (in doc/userguide/) to reflect the changes made
  • [N/A] I have updated the JSON schema (in etc/schema.json) to reflect all logging changes
    (including schema descriptions)

Describe changes:

  • Update sawp dependencies to 0.13.1 due to SPDX license compatibility. -- Upstream diff: CybercentreCanada/sawp@sawp-0.12.1...sawp-0.13.1
    Changes since v1:
  • Made the updates to the master branch
  • Updated Cargo.lock.in as well with the updated hashes.

@bmbenson bmbenson requested a review from jasonish as a code owner January 8, 2025 17:56
Copy link

github-actions bot commented Jan 8, 2025

NOTE: This PR may contain new authors.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (def22fa) to head (0083f94).
Report is 131 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12357      +/-   ##
==========================================
- Coverage   83.23%   80.57%   -2.67%     
==========================================
  Files         912      925      +13     
  Lines      257647   259292    +1645     
==========================================
- Hits       214450   208915    -5535     
- Misses      43197    50377    +7180     
Flag Coverage Δ
fuzzcorpus 56.15% <ø> (-5.07%) ⬇️
livemode 19.39% <ø> (-0.01%) ⬇️
pcap 44.20% <ø> (-0.20%) ⬇️
suricata-verify 63.40% <ø> (+0.53%) ⬆️
unittests 58.44% <ø> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work

CI : ✅
Code : good
Commits segmentation : ok
Commit messages : ⚠️ can you prefix the commit title with rust: see commit 8e408d3 for an example
Git ID set : looks fine for me
CLA : I have no access
Doc update : not needed
Redmine ticket : do we need one ?
Rustfmt : no rust
Tests : covered by current tests
Dependencies added: none :-)

@bmbenson bmbenson changed the title Update sawp dependencies to 0.13.1 due to SPDX license compatibility/v2 rust: Update sawp dependencies to 0.13.1 due to SPDX license compatibility/v2 Jan 29, 2025
@catenacyber
Copy link
Contributor

I meant the commit title, not the PR title :-)

@bmbenson
Copy link
Author

Made the requested update to the commit message, and as a bonus to the PR description! :p

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @jasonish any opinion on this license stuff ?

Copy link

NOTE: This PR may contain new authors.

@jasonish
Copy link
Member

Looks good to me, @jasonish any opinion on this license stuff ?

I like the SPDX stuff.

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants