-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust: Update sawp dependencies to 0.13.1 due to SPDX license compatibility/v2 #12357
base: master
Are you sure you want to change the base?
Conversation
NOTE: This PR may contain new authors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12357 +/- ##
==========================================
- Coverage 83.23% 80.57% -2.67%
==========================================
Files 912 925 +13
Lines 257647 259292 +1645
==========================================
- Hits 214450 208915 -5535
- Misses 43197 50377 +7180
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work
CI : ✅
Code : good
Commits segmentation : ok
Commit messages : rust:
see commit 8e408d3 for an example
Git ID set : looks fine for me
CLA : I have no access
Doc update : not needed
Redmine ticket : do we need one ?
Rustfmt : no rust
Tests : covered by current tests
Dependencies added: none :-)
I meant the commit title, not the PR title :-) |
Made the requested update to the commit message, and as a bonus to the PR description! :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @jasonish any opinion on this license stuff ?
NOTE: This PR may contain new authors. |
I like the SPDX stuff. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Previous PR: #12328
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
Describe changes:
Changes since v1: