-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra dependances #596
Extra dependances #596
Conversation
Now "extra" is: "optional", "nlp", "full" and "tests". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest some changes. If we go this way, we will only have "full" and "nlp" pip tags for now. We will add "audio" and "cv" later, but not "optional" and "tests"
Also, let's update installation instruction. Please, check contribution guide to understand how to change something in Readme.
@ayasyrev everything looks okay to me let's finish with my comment above after that we are good to merge |
Do we need to add typings from transformers for NLP related modules (datasets, models)? Right now placeholders with Any type there. Or we can do it in separate PR. |
I've tried and failed in the previous PRs. Spent a few hours on that. Seems like I could not make work type hints when they created in if-else condition. Probably I can may it work... I dont'know |
Now you can import Tokenizers and models from transformers in codebase without if-else. It makes sense, because lib might be installed with |
@DaloroAT |
Return tensorboard to main requirements. It needs for short tests. |
Add "extra" options for pip install.
If OK, add info to documentation.
Now we can move "tensorboard" to loggers and create cv requrements file