DIMTS_TRV11_001 Pull request

[Sudhir-Dimts]

Submitting the json logs for core ticketing flow and IGM of DMRC integration in TRV11 for Delhi.

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
13810658	Triggered	Generic High Entropy Secret	278e89e	TRV11/DIMTS/DMRC/Flow1/on_confirm.json	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[sourabhsaini11]

@Sudhir-Dimts
on_search_2

• items.duration format is incorrect

init

• SETTLEMENT_DETAILS tag-group is not required
• missing BUYER_FINDER_FEES_TYPE, MANDATORY_ARBITRATION and COURT_JURISDICTION tags in payments

confirm

• SETTLEMENT_DETAILS tag-group is not required
• missing BUYER_FINDER_FEES_TYPE and DELAY_INTEREST tags in payments

cancel

• order_id should match to on_confirm's order.id

on_cancel

• please provide cancellation call without error obj

common_issue

• incorrect value PT30D for tag SETTLEMENT_WINDOW, correct format is P30D
• virtual_payment_address is not required in params if SETTLEMENT_TYPE is not upi
• missing search_1 & on_search_1 pair calls
• missing flow_1(happy journey)

[Sudhir-Dimts]

Flow1 and Flow2 folders separately uploaded after creating afresh. Comments against Findings are below
on_search_2
• items.duration format is incorrect
- this parameter is received from seller NP
init
• SETTLEMENT_DETAILS tag-group is not required
-Removed the parameter
• missing BUYER_FINDER_FEES_TYPE, MANDATORY_ARBITRATION and COURT_JURISDICTION tags in payments
-Added the parameter
confirm
• SETTLEMENT_DETAILS tag-group is not required
-Removed the parameter
• missing BUYER_FINDER_FEES_TYPE and DELAY_INTEREST tags in payments
-Added the parameter
cancel
• order_id should match to on_confirm's order.id

• corrected
  on_cancel
  • please provide cancellation call without error obj
  -Now proper cancellation is provided
  common_issue
  • incorrect value PT30D for tag SETTLEMENT_WINDOW, correct format is P30D
• corrected
  • virtual_payment_address is not required in params if SETTLEMENT_TYPE is not upi
• corrected
  • missing search_1 & on_search_1 pair calls
• now provided
  • missing flow_1(happy journey)
• now provided