Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bob production request #1943

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

CrAcKy-glitch
Copy link

No description provided.

Copy link

gitguardian bot commented Feb 14, 2025

⚠️ GitGuardian has uncovered 11 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/preprod/Flow 5/file_20250211164831_1484.json View secret
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/staging/Flow 1/file_20250211161618_3213.json View secret
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/preprod/Flow 5/file_20250211164831_1484.json View secret
- - Microsoft Azure Storage Account Key 3d2449c logs/bob/Flow 1/file_20250211163801_4740.json View secret
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/staging/Flow 1/file_20250211161618_3213.json View secret
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/staging/Flow 1/file_20250211161618_3213.json View secret
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/preprod/Flow 5/file_20250211164831_1484.json View secret
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/preprod/Flow 1/file_20250211163801_4740.json View secret
- - Microsoft Azure Storage Account Key 3d2449c logs/bob/Flow 1/file_20250211163801_4740.json View secret
- - Microsoft Azure Storage Account Key 3d2449c logs/bob/Flow 2/file_20250211164831_1484.json View secret
- - Microsoft Azure Storage Account Key b7ee9e7 logs/bob/preprod/Flow 1/file_20250211163801_4740.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@CrAcKy-glitch
Copy link
Author

Hi have made the necessary changes pls do have a look

@92shreyansh
Copy link
Member

@CrAcKy-glitch Can you please move the logs under TRV10/<org_name>/

@CrAcKy-glitch
Copy link
Author

sure ill do that

@CrAcKy-glitch
Copy link
Author

CrAcKy-glitch commented Feb 17, 2025

i have moved the files to TRV10 request your review

@92shreyansh 92shreyansh added the TRV-10 Ride Hailing Services label Feb 18, 2025
@92shreyansh
Copy link
Member

Thanks for the upodate also one more fix you can also make sure that the complete flow 2 & flow 3 traqnsaction are added starting from search for that transaction_id it would be really helpful

@sourabhsaini11 Please pick up the logs and provide feedback of flow 1 for now;
@CrAcKy-glitch Due to delay from our side in stabalizing the PR we will pickup partial validation of just one flow as exception this one time

@sourabhsaini11
Copy link

@CrAcKy-glitch
on_update-ride-ended

  • timestamp should be greater than past call's timestamp

init, confirm

  • stops.instructions & fulfillments.type are sent additionally
  • for payments.params, provide valid values

track

  • order_id should match order.id created at on_confirm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TRV-10 Ride Hailing Services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants